Page MenuHomeWildfire Games
Differential D2187

standardize civ bonus technology tooltips
ClosedPublic
Actions

Authored by Nescio on Aug 18 2019, 4:55 PM.

Details

Reviewers
Gallaecio
Commits
rP22820: standardize civ bonus technology tooltips
Summary

This patch standardizes the tooltips of the simulation/data/technologies/civbonuses/*.json files.

See also D1720, D1806, D1807, D1808.

Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8909
Build 14621: Vulcan BuildJenkins
Build 14620: arc lint + arc unit

Event Timeline

Nescio created this revision.Aug 18 2019, 4:55 PM
Vulcan added a comment.Aug 18 2019, 4:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/415/display/redirect

Harbormaster completed remote builds in B8909: Diff 9382.Aug 18 2019, 4:58 PM
Gallaecio added inline comments.Aug 24 2019, 10:53 AM
binaries/data/mods/public/simulation/data/technologies/civbonuses/cart_walls.json
6

Note to self: there’s an extra space between ‘and’ and ‘+200%’, to be removed when applying the patch.

binaries/data/mods/public/simulation/data/technologies/civbonuses/maur_walls.json
7

Should we remove “City” from there?

Freagarach added a subscriber: Freagarach.Aug 24 2019, 10:57 AM
Freagarach added inline comments.
binaries/data/mods/public/simulation/data/technologies/civbonuses/maur_walls.json
7

Well, there is also Palisade Walls?

Nescio added inline comments.Aug 24 2019, 11:11 AM
binaries/data/mods/public/simulation/data/technologies/civbonuses/cart_walls.json
6

Oops, my mistake.

binaries/data/mods/public/simulation/data/technologies/civbonuses/maur_walls.json
7

And Siege Walls.

Gallaecio accepted this revision.Aug 25 2019, 10:51 AM
This revision is now accepted and ready to land.Aug 25 2019, 10:51 AM
Closed by commit rP22820: standardize civ bonus technology tooltips (authored by Gallaecio). · Explain WhySep 1 2019, 12:56 PM
This revision was automatically updated to reflect the committed changes.
Gallaecio added a commit: rP22820: standardize civ bonus technology tooltips.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
data/
technologies/
civbonuses/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 9382

View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/cart_walls.json

Loading...
View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/celt_structures.json

Loading...
View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/greek_structures.json

Loading...
View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/maur_population.json

Loading...
View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/maur_walls.json

Loading...
View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/pers_population.json

Loading...
View Options

binaries/data/mods/public/simulation/data/technologies/civbonuses/spart_population.json

Loading...
Wildfire Games · Phabricator