Fixes bug with disabled fog on water
ClosedPublic
Actions

Authored by vladislavbelov on Aug 20 2019, 2:36 AM.

Details

Reviewers

wraitii

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22737: Fixes bug with disabled fog on water. The usage of USE_FOG was introduced in…

Summary

In rP22297 usage of USE_FOG from rP20584 was reverted (it's still used in other shaders), so you didn't have a possibility to disable fog on water. The patches fixes that.

Test Plan

Apply the patch and compile the game
Run the game and make sure that the checkbox disables fog on water.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Aug 20 2019, 2:36 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/433/display/redirect

Harbormaster completed remote builds in B8933: Diff 9412.Aug 20 2019, 2:41 AM

wraitii accepted this revision.Aug 20 2019, 10:02 AM

This revision is now accepted and ready to land.Aug 20 2019, 10:02 AM

elexis edited the summary of this revision. (Show Details)Aug 20 2019, 6:26 PM

Closed by commit rP22737: Fixes bug with disabled fog on water. The usage of USE_FOG was introduced in… (authored by vladislavbelov). · Explain WhyAug 20 2019, 11:03 PM

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP22737: Fixes bug with disabled fog on water. The usage of USE_FOG was introduced in….

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

shaders/

glsl/

water_high.fs

2 lines

Diff 9424

View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_high.fs

Fixes bug with disabled fog on waterClosedPublicActions