move gastraphetes template
ClosedPublic
Actions

Authored by Nescio on Aug 20 2019, 11:48 AM.

Details

Reviewers

Stan

Commits

Summary

This patch moves athen_champion_ranged_gastraphetes.xml → mace_champion_infantry_crossbowman.xml; also corrects the <Identity> node:

<Civ> to mace, because Alexander the Great reportedly used them when besieging Tyre
<GenericName> to Champion Crossbowman
<SpecificName> to Gastraphetophoros (per https://wildfiregames.com/forum/index.php?/topic/25284-specific-name-review-units/&tab=comments#comment-378848 ); γαστραφέτης gastraphetēs means “stomach-bow”, i.e. crossbow.

(The old file was evidently started as a copy of the Athenian champion archer.)

Test Plan

Ought to be unproblematic, because this template isn't used as of yet (neither in maps nor in simulation files).

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Stan requested changes to this revision.Aug 20 2019, 12:04 PM

Stan added inline comments.

binaries/data/mods/public/simulation/templates/units/mace_champion_infantry_crossbowman.xml
28 ↗	(On Diff #9416)	It's using another file, which means there is potentially duplication.

This revision now requires changes to proceed.Aug 20 2019, 12:04 PM

Successful build - Chance fights ever on the side of the prudent.

binaries/data/mods/public/simulation/templates/units/mace_champion_infantry_crossbowman.xml
28 ↗	(On Diff #9416)	What do you mean? The simulation/templates/ file (moved in this patch) uses an art/ file, not the other way around. And there are other templates which use actors from different factions, e.g. https://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/simulation/templates/units/sele_cavalry_javelinist_b.xml