Details
Details
- Reviewers
- None
- Commits
- rP22756: Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play…
Notice that there is no code behavior change. Check that it compiles. Become an expert to still find a catch or make one up.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
source/gui/IGUIObject.cpp | ||
---|---|---|
449 ↗ | (On Diff #9435) | This sounds vaguely like something that should be an error, but existing code didn't check so "?" |
source/gui/IGUIObject.cpp | ||
---|---|---|
449 ↗ | (On Diff #9435) | I suppose it should be possible to specify a style that doesn't assign a sound to an event. |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/gui/IGUIObject.h | 44| template·<typename·T>·class·GUI; | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'template<...' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/447/display/redirect