Page MenuHomeWildfire Games

Show system_info.txt path in terminal when it's written
Needs ReviewPublic

Authored by elexis on Aug 22 2019, 8:16 PM.
This revision needs review, but there are no reviewers specified.



It should be obvious to the user that runs the program from commandline if the program writes a debug logfile, and the path to that file.
It had been added for userreporter, commands.txt, replay metadata, oos dumps, but not this file.

Test Plan

I heard debug_printf doesn't output on the terminal in windows... Also there might be more files to report.

Diff Detail

rP 0 A.D. Public Repository
Lint OK
No Unit Test Coverage
Build Status
Buildable 9010
Build 14760: Vulcan BuildJenkins
Build 14759: arc lint + arc unit

Event Timeline

elexis created this revision.Aug 22 2019, 8:16 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Stan added a subscriber: Stan.Sep 30 2019, 5:10 PM

Indeed debug_printf doesn't work on windows but that's because we use OutputDebugStringW which redirects to a special debug output instead

see source/lib/debug.cpp and source/lib/sysdep/os/win/wdbg.cpp

Since it's not really used unless you rely on (Which is why I use btw)

We could even disable it for windows for releases as it has a bad performance impact. However we don't do that many debug writes.

As for other files being written, I guess you could write in the log when printing screenshots and saving the game if that's not already done. Also for user.cfg and the like.