Differential D2227

Fix rP22753 error in Promotion when promoting an entity that died on the same turn
ClosedPublic
Actions

Authored by wraitii on Aug 25 2019, 8:12 PM.

Details

Reviewers: None
Commits: rP22808: Fix rP22753 error in Promotion when promoting an entity that died on the same…

Summary

As reported by elexis on rP22753.

Add a regression test.

Test Plan

Confirm that this no longer happens (replay).

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

master_up

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 9081
Build 14878: Vulcan Build	Jenkins
Build 14877: arc lint + arc unit

Event Timeline

wraitii created this revision.Aug 25 2019, 8:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/491/display/redirect

Harbormaster completed remote builds in B9081: Diff 9510.Aug 25 2019, 8:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 31 2019, 2:38 PM

Closed by commit rP22808: Fix rP22753 error in Promotion when promoting an entity that died on the same… (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP22808: Fix rP22753 error in Promotion when promoting an entity that died on the same….

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

simulation/

components/

Promotion.js

3 lines

tests/

test_Promotion.js

11 lines

Diff 9510

View Options

binaries/data/mods/public/simulation/components/Promotion.js