Page MenuHomeWildfire Games

correct Greek specific names of structures
ClosedPublic

Authored by Nescio on Aug 25 2019, 9:20 PM.

Details

Summary

This patch corrects the structure specific names for the Greek factions (athen, mace, ptol, sele, spart), as discussed with @Anaxandridas ho Skandiates at https://wildfiregames.com/forum/index.php?/topic/25268-specific-name-review-structures/
Related: D1750 (kush), D1757 (brit, gaul), D1935 (pers), D1999 (rome), D2025 (technologies).

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Aug 25 2019, 9:20 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/495/display/redirect

Stan added a comment.Dec 16 2019, 9:46 AM

Nescio aren't we missing some now for Amphiteaters, sorry I totally forgot about this patch :/

Amphitheatres are Italic or Roman, not Greek.

Stan requested changes to this revision.Dec 16 2019, 12:18 PM

Can you rebase the patch? Sorry for the inconvenience...

This revision now requires changes to proceed.Dec 16 2019, 12:18 PM
Stan accepted this revision.Dec 16 2019, 12:19 PM

Lol too slow XD

This revision is now accepted and ready to land.Dec 16 2019, 12:19 PM
This revision was landed with ongoing or failed builds.Dec 16 2019, 12:30 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Dec 16 2019, 12:30 PM

D2155 and D2157 are also correcting some specific names.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/773/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1289/display/redirect