Page MenuHomeWildfire Games

Do not show Boudica as an idle worker

Authored by Boudica on Mar 15 2017, 11:26 PM.



This issue has been a great issue for Boudica, and this unpleasant bug has been bugging her to a great extent. She shall in no case be considered an idle worker, don't you agree? Let's leave this open for a discussion, but be notified that Boudica can as well burn your house down if you once again call her an idler.

Thank elexis for input and cooperation on this patch. The hard work has payed off.

Test Plan

The changes were trivial to test, i hope no hidden problem could emerge.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Boudica created this revision.Mar 15 2017, 11:26 PM
elexis accepted this revision.Mar 16 2017, 2:25 AM
 (00:25:43) elexis: Boudica: what was the input.js change for ?
(00:26:07) Boudica: it was actually kind of harder to find out why it must be updated too
(00:26:12) Boudica: i'll explain
(00:26:48) Boudica: when repeatedly selecting idle worker, it remembers the last selected one to select the next one
(00:27:19) Boudica: for this, it actually switches order of the idle classes, so that the class of the selected worker comes first
(00:28:15) elexis: input.js is a mess

The line "idleClasses": classes.slice(currIdleClassIndex, classes.length).concat(classes.slice(0, currIdleClassIndex)) few lines above reveals the functionality (that coincides with the actually testable functionality, first all females are selected, then the males etc.. Verify by training a new female at the CC (so it has a higher entity ID than the other females and males). Also notice Boudica still correctly shows up as an idle military unit if not in action.

We were discussing whether classes should be renamed to classesPatternList, but doesn't seem worthwhile.

This revision is now accepted and ready to land.Mar 16 2017, 2:25 AM
This revision was automatically updated to reflect the committed changes.