Page MenuHomeWildfire Games

Further fixes for Generalized Attack D2092/rP22754 : don't early-return but continue if an entity does not have a receiver, and polar sea triggers fix
ClosedPublic

Authored by wraitii on Aug 31 2019, 1:51 PM.

Details

Summary

As reported by Freagarach for D2092/rP22754.

Test Plan

Check that polar sea works correctly, and notice that the new code allows taking capture if the entity does not have health.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Aug 31 2019, 1:51 PM
Owners added a subscriber: Restricted Owners Package.Aug 31 2019, 1:51 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/518/display/redirect

elexis retitled this revision from Further fixes for rP22754 : don't early-return but continue if an entity does not have a receiver, and polar sea triggers fix to Further fixes for Generalized Attack D2092/rP22754 : don't early-return but continue if an entity does not have a receiver, and polar sea triggers fix.Aug 31 2019, 2:24 PM
elexis edited the summary of this revision. (Show Details)

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/9/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/13/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Sep 1 2019, 9:29 AM
This revision was automatically updated to reflect the committed changes.