Page MenuHomeWildfire Games

Fix modifiers affecting player entity following ModifiersManager component in rP22767
ClosedPublic

Authored by wraitii on Aug 31 2019, 2:30 PM.

Details

Summary

As reported in #5572, there was an issue with rP22767 - modifiers affecting the player entity itself were not applying.

The reason was that the cache was not correctly reset. This is now done.

Adds a regression test for this case.

Test Plan

Test replay on #5572

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Aug 31 2019, 2:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/519/display/redirect

http://irclogs.wildfiregames.com/2019-08/2019-08-29-QuakeNet-%230ad-dev.log

22:48 < minohaka> elexis: when there's a bug such as the wonder population one, how do you know where to look in case you want to give a try to fixing it? Like is that info in the ticket
22:55 < minohaka> sometimes I wish I knew the codebase better
22:59 < minohaka> I wish I could point to the file + line of code that caused it

@minohaka in case you still have wishes on this issue, perhaps you want to read or test or review it or something.

elexis retitled this revision from Fix rP22767 - modifiers affecting a player entity now register correctly. to Fix modifiers affecting player entity following ModifiersManager component in rP22767.Aug 31 2019, 2:41 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/10/display/redirect

minohaka accepted this revision.Aug 31 2019, 8:05 PM

It works, this fixes the wonder population bonus not taking effect

This revision is now accepted and ready to land.Aug 31 2019, 8:05 PM