Page MenuHomeWildfire Games

Make CanPatrol and CanGuard depend on the presence of the appropriate component
Needs ReviewPublic

Authored by wraitii on Sun, Sep 1, 6:32 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This makes these two special states follow suit from other 'optional' states, such as attacking, gathering, moving...

Add a placeholder Patrol component.

Related to flamewars on D156, see also D1960.

Test Plan

Agree that this is desirable.

Unit TestsFailed

TimeTest
0 msJenkins > TestComponentScripts::test_scripts
Test failed: L"Running script simulation/components/tests/test_GuiInterface.js" Assertion failed: scriptInterface.LoadScript(pathname, content)
0 msJenkins > cxxtest-debug-gcc6.xml::[failed-to-read]
Failed to read test report file /zpool0/trunk/cxxtest-debug-gcc6.xml org.dom4j.DocumentException: Error on line 1 of document : Content is not allowed in prolog. Nested exception: Content is not allowed in prolog. at org.dom4j.io.SAXReader.read(SAXReader.java:482)
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestBase32::test_base32
0 msJenkins > TestBase32::test_base32_lengths
View Full Test Results (2 Failed · 315 Passed)

Event Timeline

wraitii created this revision.Sun, Sep 1, 6:32 PM
Owners added a subscriber: Restricted Owners Package.Sun, Sep 1, 6:32 PM
Vulcan added a comment.Sun, Sep 1, 6:33 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/548/display/redirect

Vulcan added a comment.Sun, Sep 1, 6:34 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/39/display/redirect