Page MenuHomeWildfire Games

restore legionary scutum
AbandonedPublic

Authored by Nescio on Sep 1 2019, 7:22 PM.

Details

Reviewers
Gallaecio
Stan
Summary

Somehow the art/actors/props/units/shields/rome_scutum_legionary.xml ended up emptied, which shouldn't have happened. This patch restores its contents and should solve the concerns raised at rP22818, rP22819, and rP22823.
While at it, I shortened variant names and removed unnecessary white lines.

Test Plan

Check it works

Event Timeline

Nescio created this revision.Sep 1 2019, 7:22 PM
Owners added a subscriber: Restricted Owners Package.Sep 1 2019, 7:22 PM
Vulcan added a comment.Sep 1 2019, 7:23 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/43/display/redirect

elexis awarded a token.Sep 1 2019, 7:23 PM
Vulcan added a comment.Sep 1 2019, 7:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/552/display/redirect

Stan added a comment.Sep 1 2019, 7:37 PM

Thanks for the patch. The simplification of the variant name is nice, however it recently came to my attention that props synchronize with their parents variant name. So if the parent has a 'D' variant only one of the elements of the second group will be picked when the parents is in that variant (Dunno if I make sense) Hence why its better to have a little more specific names for variants.

binaries/data/mods/public/art/actors/props/units/shields/rome_scutum_legionary.xml
1

You can remove the standalone as well while at it :)

Nescio updated this revision to Diff 9594.Sep 1 2019, 7:40 PM
Vulcan added a comment.Sep 1 2019, 7:45 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/554/display/redirect

Vulcan added a comment.Sep 1 2019, 8:22 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/45/display/redirect

I’ve just restored the file with its previous content in https://code.wildfiregames.com/rP22830

Sorry about all this trouble, applying the patch was really unclean. I had trouble with both «svn patch» and «patch -uN» due to the spaces in file names, but even when I solved that the patch did not apply the file renamings as intended.

But the problems are solved now, aren't they? That's what matters.

Nescio abandoned this revision.Sep 1 2019, 10:36 PM