Page MenuHomeWildfire Games

standardize gather technology tooltips
ClosedPublic

Authored by Nescio on Sep 2 2019, 9:41 PM.

Details

Summary

This patch standardizes the tooltips of gather technologies, per https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Stats
Flavour text strings are moved from the "tooltip" to the "description" entry.

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Sep 2 2019, 9:41 PM
Vulcan added a comment.Sep 2 2019, 9:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/57/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/566/display/redirect

Freagarach added inline comments.
binaries/data/mods/public/simulation/data/technologies/gather_farming_plows.json
3 ↗(On Diff #9608)

The first part of the description is plural (iron plows) then it is referenced to in singular (a horse drawn instrument). Is that correct? To me it looks strange, but I am no native English speaker ;)

binaries/data/mods/public/simulation/data/technologies/gather_fishing_net.json
3 ↗(On Diff #9608)

Using nets (...) Or something? Because in other techs you do move similar lines.

binaries/data/mods/public/simulation/data/technologies/gather_mining_silvermining.json
7 ↗(On Diff #9608)

So interesting that one can just choose to strike such a high value vein :)

Nescio updated this revision to Diff 9618.Sep 3 2019, 6:59 PM
Vulcan added a comment.Sep 3 2019, 7:00 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/66/display/redirect

Vulcan added a comment.Sep 3 2019, 7:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/575/display/redirect

Gallaecio accepted this revision.Sep 15 2019, 1:34 PM
This revision is now accepted and ready to land.Sep 15 2019, 1:34 PM
This revision was automatically updated to reflect the committed changes.