buzzard
ClosedPublic
Actions

Authored by Nescio on Sep 3 2019, 11:40 AM.

Details

Reviewers

Freagarach

Commits

rP23977: Move gaia/fauna_hawk -> birds/buzzard.

Summary

This patch moves the gaia/fauna_hawk.xml template to birds/buzzard.xml, because according to the relevant forum post, our hawk is actually a common buzzard (Buteo buteo).
Birds do not inherit from template_gaia.xml, do not provide any resources, and do not interact, do not even have <Identity>, therefore they don't really belong in the gaia/ folder. A separate birds/ folder makes sense (cf. rubble/, territory_pulls/) and allows for future additions (eagles, falcons, hawks, vultures, etc.).

Apply the patch, then run the following line to adjust all map files:

find binaries/data/mods/public/maps/ \( -name '*.js' -o -name '*.json' -o -name '*.xml' \) -print0 | xargs -0 sed -i 's,gaia/fauna_hawk,birds/buzzard,g'

Similar patches include:

Test Plan

Check for mistakes.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Sep 3 2019, 11:40 AM

Nescio added a reviewer: Restricted Owners Package.

Nescio added a subscriber: wowgetoffyourcellphone.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/60/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/569/display/redirect

Harbormaster completed remote builds in B9198: Diff 9612.Sep 3 2019, 11:44 AM

I believe you forgot all the maps where they are used ?

EDIT: nevermind.

EDIT2: Will likely break mods they should be notified.

EDIT3: Someone with Linux will have to commit this...

This doesn't look too bad, but I'm not sure we should have a template folder specific to birds.

gaia/birds/buzzard.xml then?
Birds inherit from template_bird.xml, not from template_gaia.xml, and don't provide any resources, as files inside gaia/ do.

@bb, interested in reviewing this one?

Nescio mentioned this in D2774: gaia/fauna_fish* → gaia/fish/*.May 31 2020, 5:50 PM

Nescio edited the summary of this revision. (Show Details)May 31 2020, 5:57 PM

Nescio mentioned this in D2914: rename templates: javelinist → javelineer.Jul 27 2020, 3:25 PM

I agree with the birds folder, since it follows the same structure as the other folders.
One could argue that they should be in the GAIA folder, though that would imply it inherits from template_gaia. One could do that, but it means the bird-template would get larger (lots of disabling besides the enabling). While I think that would technically be correct I am not convinced it is worth the hassle. If one goes that route it seems logical to also split the fauna/flora/geological in the "gaia" folder into separate folders?

Nescio mentioned this in D2925: deprecate campaigns/ folder.Aug 3 2020, 11:03 AM

Nescio edited the summary of this revision. (Show Details)Aug 3 2020, 11:52 AM

Nice change, complete and correct.
This forum post pulled me over the line.

This revision is now accepted and ready to land.Aug 18 2020, 9:23 AM

Freagarach removed a reviewer: Restricted Owners Package.Aug 20 2020, 10:22 AM

Closed by commit rP23977: Move gaia/fauna_hawk -> birds/buzzard. (authored by Freagarach). · Explain WhyAug 20 2020, 11:16 AM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP23977: Move gaia/fauna_hawk -> birds/buzzard..

Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Aug 20 2020, 11:16 AM

Thanks! That's one incorrectly named template less. How about fish (D2774)? Those are not really fauna either, since they inherit from template_gaia_fish.xml, not template_unit_fauna.xml.

Nescio mentioned this in D1009: introduce subfolders for flora templates.Sep 17 2020, 5:43 PM

Nescio mentioned this in D1010: introduce subfolders for geology templates.Sep 19 2020, 10:41 AM