Page MenuHomeWildfire Games

gaia/fauna_hawk → birds/buzzard
Needs ReviewPublic

Authored by Nescio on Sep 3 2019, 11:40 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch moves the gaia/fauna_hawk.xml template to birds/buzzard.xml, because according to the relevant forum post, our hawk is actually a common buzzard (Buteo buteo).
Birds do not inherit from template_gaia.xml, do not provide any resources, and do not interact, do not even have <Identity>, therefore they don't really belong in the gaia/ folder. A separate birds/ folder makes sense (cf. rubble/, territory_pulls/) and allows for future additions (eagles, falcons, hawks, vultures, etc.).

Apply the patch, then run the following line to adjust all map files:

find binaries/data/mods/public/maps/ \( -name '*.js' -o -name '*.json' -o -name '*.xml' \) -print0 | xargs -0 sed -i 's,gaia/fauna_hawk,birds/buzzard,g'

See also D2774.

Test Plan

Check for mistakes.

Event Timeline

Nescio created this revision.Sep 3 2019, 11:40 AM
Nescio added a reviewer: Restricted Owners Package.
Nescio added a subscriber: wowgetoffyourcellphone.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/60/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/569/display/redirect

Stan added a subscriber: Stan.EditedSep 3 2019, 11:51 AM

I believe you forgot all the maps where they are used ?

EDIT: nevermind.

EDIT2: Will likely break mods they should be notified.

EDIT3: Someone with Linux will have to commit this...

Stan added a comment.Jan 6 2020, 9:59 PM

This doesn't look too bad, but I'm not sure we should have a template folder specific to birds.

gaia/birds/buzzard.xml then?
Birds inherit from template_bird.xml, not from template_gaia.xml, and don't provide any resources, as files inside gaia/ do.

Nescio added a subscriber: bb.May 31 2020, 5:30 PM

@bb, interested in reviewing this one?

Nescio edited the summary of this revision. (Show Details)May 31 2020, 5:57 PM