Page MenuHomeWildfire Games

Heroes cost increase and redundant components inheritance
ClosedPublic

Authored by Grugnas on Mar 16 2017, 7:01 PM.

Details

Summary

Heroes cost increased, highlighting their role as unique unit with unique effects.
Templates components inheritance is highlighted too.
mauryan Chanakya parent template changed

Test Plan

Heroes cost increased, highlighting their role as unique unit with unique effects.
Templates components inheritance is highlighted too.
mauryan Chanakya parent template changed

Training heroes will be more expensive in order to properly represent their influence on the game.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1994
Build 3197: Vulcan BuildJenkins
Build 3196: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Grugnas updated this revision to Diff 1005.Mar 30 2017, 11:41 AM

Chanakya health fix

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/638/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/639/ for more details.

fatherbushido requested changes to this revision.Mar 30 2017, 3:48 PM

Not introduced by the patch, but while at cleaning, let's actually clean. If I want to know the cost of a hero infantry pikeman, I have to check 3 templates:

<Resources>
  <food>200</food>
  <metal>250</metal>
</Resources>

Then

<Resources>
  <metal>200</metal>
</Resources>

And

<Resources>
  <wood>50</wood>
</Resources>

To get F200 W50 M200

Also strangely for the spearman the last step is

<Resources>
  <wood op="add">50</wood>
</Resources>

Also check inheritance of that mauryan healer hero. I pointed out one to be explicit. Find the others.

binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
39

Already asked to change/check that

This revision now requires changes to proceed.Mar 30 2017, 3:48 PM
Grugnas updated this revision to Diff 1020.Mar 30 2017, 9:42 PM
Grugnas edited edge metadata.

Watching at Children templates is easier than the previous diff.
I still think that distinguishing the cost of units sharing the same parent template is needed to understand the reason of such resource.
more Chanakya redundanced are now nuked.

Owners added a subscriber: Restricted Owners Package.Mar 30 2017, 9:42 PM
Grugnas updated this revision to Diff 1021.Mar 30 2017, 9:47 PM
fatherbushido added inline comments.Mar 30 2017, 10:06 PM
binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
50–53

check it too

Build has FAILED

Link to build: http://jw:8080/job/phabricator/649/
See console output for more information: http://jw:8080/job/phabricator/649/console

fatherbushido requested changes to this revision.Apr 1 2017, 1:58 PM
fatherbushido added inline comments.
binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
50–53

the entry above

This revision now requires changes to proceed.Apr 1 2017, 1:58 PM
Grugnas updated this revision to Diff 1050.Apr 1 2017, 3:22 PM
Grugnas edited edge metadata.

chanakya Selectable redundance remove.

fatherbushido requested changes to this revision.Apr 2 2017, 11:07 AM
fatherbushido added inline comments.
binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
34

Try again?

This revision now requires changes to proceed.Apr 2 2017, 11:07 AM
Grugnas updated this revision to Diff 1087.Apr 3 2017, 11:31 AM
Grugnas edited edge metadata.

Removed class Hero and Soldier for Chanakya template.

fatherbushido added inline comments.Apr 3 2017, 11:52 AM
binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
34

While at it consider if Soldier classe should be in the parent template or add for cavalry and infantry one (and elephant - needs to check that: see first what is done for champs).

55–56

perhaps just keep the parent one which is not really different or just change that parent one as it's mainly overwriten by all/ most of its childs.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/687/ for more details.

fatherbushido requested changes to this revision.Apr 4 2017, 11:33 AM

You should specify in the summary that you add a capture attack for the healer hero and check that there is not conflict in the code between that and its support class (which would be interesting).

binaries/data/mods/public/simulation/templates/template_unit_hero.xml
22 ↗(On Diff #1087)

If you don't use relative templates in child templates. Imo that part can be nuke (and moved for the healer hero)

binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
8–20

Not checked

This revision now requires changes to proceed.Apr 4 2017, 11:33 AM
Grugnas updated this revision to Diff 1096.Apr 4 2017, 7:37 PM
Grugnas edited edge metadata.

template_unit_hero: removed the UnitMotion entry and added to the missing children.
removed the Cost entry.
Chanakya: removed the garrison_hero aura since it is inherited.

Vulcan added a comment.Apr 4 2017, 8:21 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/693/ for more details.

Take care also of the default stance of the healer hero

Grugnas updated this revision to Diff 1275.Apr 16 2017, 10:37 AM

Chanakya default stance is Defensive now.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/784/ for more details.

fatherbushido resigned from this revision.Apr 23 2017, 6:05 PM

I made some tables.

Currently champ policy is

  • infantry 125f 100w 75m
  • cavalry 250f 100w 100m
  • +25w -25m for swordmen.

Basically we take here the same policy but x2. It fixes the current big inconsistency.

Other changes:
Training time.
Repeat attack of swordmen made consistent with the related champ.

Armor is keeped as it is now but use relative template. No clue if it should be in the scope of that patch. Imo don't do that here.

Request changes:

  • inlined comments
  • also +10 training time for elephant hero
binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry.xml
8–9

add 10 build time

10–11

200 wood

10–11

500 food but seems too much. 400 food sounds ok

binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_archer.xml
21

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_javelinist.xml
21

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_spearman.xml
22

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_swordsman.xml
22

-50 wood

binaries/data/mods/public/simulation/templates/template_unit_hero_infantry.xml
13

200 wood

binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_archer.xml
18–19

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_javelinist.xml
21

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_pikeman.xml
28

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_spearman.xml
28

nuke

binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml
22

-50 wood

fatherbushido requested changes to this revision.May 25 2017, 11:17 AM
fatherbushido added a subscriber: fatherbushido.

(Don't change other things else I would need to spend again time on that)

This revision now requires changes to proceed.May 25 2017, 11:17 AM
fatherbushido added inline comments.May 27 2017, 1:27 PM
binaries/data/mods/public/simulation/templates/template_unit_hero_infantry.xml
42

No need imo

Grugnas updated this revision to Diff 2240.May 27 2017, 2:04 PM
Grugnas edited edge metadata.

patch updated in order to reflect recent commits.
Costs retweaked in order to properly scale as fatherbushido pointed out.

Grugnas updated this revision to Diff 2246.May 27 2017, 2:52 PM

properly set the values.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1375/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1381/ for more details.

Fine. The healer hero needs to be rebased but I'll do it when commiting.
The change make consistent hero cost with champion cost and hero cost between them. The policy is mainly 2x champ cost exepting for some values.
Armour uses relative templates and are not changed.

fatherbushido added inline comments.May 29 2017, 6:45 PM
binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml
56

Not at the wrong place :p

This revision was automatically updated to reflect the committed changes.
elexis added inline comments.Jun 2 2017, 10:15 PM
ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_swordsman.xml
14 ↗(On Diff #2306)

(likewise)

21 ↗(On Diff #2306)

Why add the inconsistency if the rest was about removing inconsistencies in the cost?

ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_spearman.xml
14 ↗(On Diff #2306)

D186 -> ack

ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml
14 ↗(On Diff #2306)

Weren't they strong enough? PrepareTime could be set to 350 if it's about making it equal to template_unit_champion_infantry_swordsman.

They now deal 33% more damage in the same time (hack attack could be reduced)

20 ↗(On Diff #2306)

why not op="add" -50?

Grugnas added inline comments.Jun 3 2017, 2:44 PM
ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml
14 ↗(On Diff #2306)

you are right, there was some confusion about prepare time.

20 ↗(On Diff #2306)

Honestly i never used such thing but it makes sense.

elexis added inline comments.Jun 3 2017, 2:47 PM
ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml
14 ↗(On Diff #2306)

Can I revert that +33% attack damage per second for sword heroes (by reducing their Hack attack proportionally) or was that quite big buff needed for anything?

fatherbushido added inline comments.Jun 3 2017, 4:50 PM
ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml
14 ↗(On Diff #2306)

We have now just an hero with 2x attack stat compares to the mathcing champ. So in fact, now it's consistent, and before they were a little above the other hero (if we think in champ - hero constistency).
Anyway it's hard to notice for hero.

20 ↗(On Diff #2306)

What do you say Grugnas? You use it below.

20 ↗(On Diff #2306)

Or you mean with the "-"?