This uses the functionality introduced in rP22769 in the only template that benefits for now.
Details
Details
- Reviewers
bb - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23431: Merge kushites champion infantry attack bonusses
Verify this is more correct than what it was because any unit who would have both classes would previously have had 1.3*1.3 times the bonus.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/79/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/588/display/redirect
Comment Actions
Instead of two bonuses, it is now one, which has exactly the same in-game effect. (Unless one would have a unit with both the Champion and the Hero class, in that case the bonus against it will be only 1.3 while previously it would have been 1.3*1.3.)
Comment Actions
If there is no difference, then why change? (I don't think there is any entity which has both the Champion and Hero class.)
Comment Actions
Looks correct and complete to me
If someone wants to add a bonus to two classes, that, hypothetical, person shouldn't see this "wrong" example, rather see the correct one, even though in this case the effect is the same. Also who knows if there will be a unit "Champion+Hero" ;)
Lastly, it is less code after all...