These XMPP Certificate error strings were added untranslated in rP21901 during string freeze last release and should become translated now.
Details
Details
- Reviewers
- None
- Commits
- rP22875: Translate lobby TLS certificate error strings following rP21901 and string…
- Trac Tickets
- #4705
Install pology and run the source/tools/l10n/updateTemplates.py script. Notice that the new strings (should) show up in the transifex pology files.
If you fail to install pology because there are no repositories available, compare this piece of code against the other translated strings, and in case this is committed, check the next autobuild committed pology files to verify.
To test that the strings are actually displayed,
change in default.cfg:
server = "lobby2.wildfiregames.com" ; Address of lobby server
and in XmppClient::onDisconnect:
CreateGUIMessage("system", "disconnected", std::time(nullptr), "reason", TLSErrorToString(gloox::CertWrongPeer));
for instance.
The string should show up in engine.pot, for example:
#: lobby/XmppClient.cpp:1102 msgid "Player already logged in" msgstr ""
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/110/display/redirect
| source/lobby/XmppClient.cpp | ||
|---|---|---|
| 1099 ↗ | (On Diff #9680) | Notice that this cannot become a static const (member or local) because the target language can change during calls. |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/619/display/redirect
Comment Actions
If you fail to install pology because there are no repositories available, compare this piece of code against the other translated strings, and in case this is committed, check the next autobuild committed pology files to verify.
Check:
https://code.wildfiregames.com/rP22896#change-yysGWEA7AmCF