Page MenuHomeWildfire Games

Add build order to unit commands to play different sounds for build and repair
Needs ReviewPublic

Authored by Angen on Mon, Sep 9, 7:35 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Entities have different sound entries for build and repair orders in templates but currently only one is used.
This patch is using build order for foundations and repair order for anything else keeping hotkeys, mouse clicks and actions modified with button grouped,
so there is no change for user.

Test Plan
  1. Check code
  2. Check logic
  3. Check sound is played in both situations

Event Timeline

Angen created this revision.Mon, Sep 9, 7:35 PM
Owners added a subscriber: Restricted Owners Package.Mon, Sep 9, 7:35 PM
Vulcan added a comment.Mon, Sep 9, 7:36 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/115/display/redirect

Vulcan added a comment.Mon, Sep 9, 7:39 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...

binaries/data/mods/public/gui/session/unit_actions.js
| 625| »   »   »   switch·(tradingDetails.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/624/display/redirect

Angen updated this revision to Diff 9688.Mon, Sep 9, 7:48 PM
Angen edited the test plan for this revision. (Show Details)

add entry to template, fix repair command back

Vulcan added a comment.Mon, Sep 9, 7:49 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/116/display/redirect

Stan awarded a token.Mon, Sep 9, 7:50 PM
Vulcan added a comment.Mon, Sep 9, 7:51 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...

binaries/data/mods/public/gui/session/unit_actions.js
| 625| »   »   »   switch·(tradingDetails.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/625/display/redirect