Why we have these duplicate consts? more of them below

empty todo?

]; on next line, below too

ever written too?

unused?

isn't this empty the first few usages?

2 * PI and spaces

unneeded comment

Math.

Was thinking if we could skip the while, but meh

2 * Pi

hmmmpfff 15 => 45 => 20 lolz

nuke .0

whitespaces

whitespaces

whitespaces

whitespaces

whitespaces

whitespaces and trailing comma

whitespaces

ok, we create an array of 1 element ask for its length and loop over it : nucular

whitespaces

...of its former era.?

Time in minutes between the increases of the water level.?

Number of meters the waterheight increases every step.?

Would be nice if we have a couple of these sentences, some suggestions:

"The rivers are standing high, we need to find a save place!"
"We have got to find dry ground, our lands will drawn soon!"
"The lakes start swallowing the land, we have to find shelter!"

don't we have a timer component for that?

cmpTimer

It is meant to get all entities here I guess, perhaps make a function for that?

cmpPosition

units can stay in shallow water, so do trees, mines etc. perhaps nice to take this into account. no strong opinion

Move below health check

Move out of loop

siege == Unit right? but siege won't sink in the ground when under water... perhaps use "Organic" class

We already called GetPosition so if we pull that out of the check we don't need this.

only used once, inline

In most entity change function, the new ent in created first, afterwards the old one is destroyed. With that some of the variables above can be inlined.

bummer there is no setXYZRotation

cmpTimer

I did prefer to have the constant 60 * 1000 behind the ms time

periods and caps
also fx and fz

for ... of indeed bad since i-1 used

3 == steepness? (dunno)

fx != fractionToTiles(fx) so not the same. (we don't want duplicate fractionToTiles execution so it requires new variable guess)

shouldn't that be clLast?

(Leftover. Did change the textures back an forth)

These actually seem useful to me, since you can insert a texture here and have that texture appear right below the forests. If we'd replace all forest floor occurances with the hill textures, we'd have to start looking. And it's not unlikely that someone will want to add a forest floor texture. It's just that I was completely unable to find one that fits.

(Leftover; we don't have Lava on this map, so TODO was nuke after fixing the volcano)

Same story as on survival and many others - its the createFood function which grossly takes that as a default. But I'll pass it explicitly to make it more obvious, good point.

createLayeredPatches. Passing explicitly now. Actually wondering whether they look artistically good enough, or whether that map would be better off being more monotonous.

Is. Removing the two misleading entries.

let mAngle = bbAngle; pointless, entire loop pointless (since the intention is to keep a distance < x but > y to the berries, but those arent placed first here.

This just reflects the coding process

Yes sir (this was a leftover from rewriting 4 different forest methods, since all of them had some weird issues which I luckily don't recall)

Looked for other bush models, but that only other one seems to be a dupe.
Also reusing numStragglers here seems to make totalTrees lie, but don't really care.

Thanks! Also misses water waviness, since those puddles shouldn't have ocean waves

per step

Sure, good idea

Omg did I write that piece of code? How on earth did that not go OOS, nor OOS on rejoin. Thx!

Probably useful, making a separate proposal and if that makes it in, will change this occurance

Was worried about units being able to do things underwater, but they will just become wiped out with the next increment and this feature was requested by hannibal too. Since template_unit_infantry has <Height>2.5</Height>, going for +1

The idea is that owned entities either become visual actors or die. I guess we can keep those siege engine remains underwater, because players will not confuse them more with alive units as they might be confused with existing buildings becoming actors. So yay.
Also relics and potentially others, but "Organic" seems to be a wise decision.

Tbh I find it more clean to recall the set of properties to be transfered explicitly than mixing calls to both entities

Could implement, could also not

me too, it can be considered the unit

That's the distance between those 2 textures. If this is used for painting dirt patches, we can increase the size of the dirt patches this way f.e.

ix, iz, done.

The idea is that the smoke is only placed onto the lava-area, so creating clLava to make it more obvious.

Making fx, ..., iz, local variables of the new helper function was what broke the volcano smoke. Took me 4 hours one night and 5 minutes today.

Actually the color was equivalent to black, which was only noticeable when using the worst ugliest water settings possible. So keeping the hueness and saturation, just increasing the value of the water color a bit.

have got to -> have to