In rP18964 / #3934 we have made the code agnostic of resource types with few exceptions.
One of them is setup_resources.xml.
If a mod wants to insert a new resource type, it has to overwrite setup_resources.xml.
But that makes it impossible to launch two mods which each insert one resource.
It also means that a mod which changes the icon of one resource type to something more attractive won't work with another mod which inserts a new resource.
By splitting this file per resource type, these issues are undermined.
Details
Details
- Reviewers
wraitii - Commits
- rP24531: Allow mods to insert or delete individual resource icons more easily.
- Trac Tickets
- #3934
Notice that this approach also addresses Vladislavs recommendation to load all textures at XML parsing time rather than at JS runtime (D1745).
Make sure that the python checkrefs script is happy.
In case of commit, update the wiki page ModdingResources and Mod_Layout and inform modders.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/320/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/835/display/redirect
Comment Actions
Make sure that the python checkrefs script is happy.
Checkrefs complains about the png files being unused before and after the patch, amongst 1500 other matches.