Since the caller to IGUIButtonBehavior::DrawButton has to pass all arguments needed for the DrawSprite call, there is actually more duplication introduced by passing those arguments rather than just doing the logic deciding which sprite to use in that function.
Details
Details
- Reviewers
- None
- Commits
- rP23008: Remove little IGUIButtonBehavior::DrawButton duplication.
Confirm that code behavior has not changed and that this will be most easily to review/audit if the commit is not extended further.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/854/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/855/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/339/display/redirect