Page MenuHomeWildfire Games
Differential D2334

Fix restartColorFade being passed too many arguments
ClosedPublic
Actions

Authored by Stan on Sep 28 2019, 1:59 PM.

Details

Reviewers
elexis
Silier
Commits
rP24158: Remove useless arguments from colorFades.js, update comments, and remove…
Summary

When running SonarQube on the code I get a few warnings. This patch fixes one of them

'This function expects 1 argument, but 6 were provided.'

Test Plan

Test that it's correct.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Sep 28 2019, 1:59 PM
Vulcan added a comment.Sep 28 2019, 1:59 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/857/display/redirect

Harbormaster failed remote builds in B9637: Diff 9994!Sep 28 2019, 1:59 PM
Vulcan added a comment.Sep 28 2019, 2:00 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/341/display/redirect

Stan updated this revision to Diff 9996.Sep 28 2019, 3:05 PM
Vulcan added a comment.Sep 28 2019, 3:09 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/859/display/redirect

Vulcan added a comment.Sep 28 2019, 3:09 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/343/display/redirect

Harbormaster failed remote builds in B9639: Diff 9996!Sep 28 2019, 3:09 PM
elexis added a comment.Sep 28 2019, 3:41 PM

Not becoming curious as to why there is the discrepancy?

Stan added a comment.Sep 28 2019, 3:45 PM

Well it was in rP18628

The discrepancy might be a typo with startColorFade which takes 6 arguments. Since you committed that patch you might know more than me on the matter.

Silier accepted this revision.Sep 9 2020, 4:12 PM
Silier added a subscriber: Silier.

missed in https://code.wildfiregames.com/rP14702

binaries/data/mods/public/gui/common/colorFades.js
153 ↗(On Diff #9996)

wanna remove this comment, or better state it is using global object to take parameters and ref to startColorFade parameters

This revision is now accepted and ready to land.Sep 9 2020, 4:12 PM
This revision was landed with ongoing or failed builds.Nov 11 2020, 11:58 AM
Closed by commit rP24158: Remove useless arguments from colorFades.js, update comments, and remove… (authored by Stan). · Explain Why
This revision was automatically updated to reflect the committed changes.
Stan added a commit: rP24158: Remove useless arguments from colorFades.js, update comments, and remove….
Owners added a subscriber: Restricted Owners Package.Nov 11 2020, 11:58 AM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
common/
33 lines

Diff 13851

View Options

ps/trunk/binaries/data/mods/public/gui/common/colorFades.js

Loading...
Wildfire Games · Phabricator