Removes unused methods and hides private member
ClosedPublic
Actions

Authored by vladislavbelov on Oct 1 2019, 6:02 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23025: Removes unused methods and hides private member.

Summary

Subj.

Test Plan

Apply the patch and compile the game
Run the game and make sure that everything works
Run tests and make sure that all tests are passed as before the patch.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Oct 1 2019, 6:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/372/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/graphics/GameView.h
|  35| class·CGameView·:·private·Scene
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCGameView:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/888/display/redirect

Harbormaster completed remote builds in B9680: Diff 10037.Oct 1 2019, 6:12 PM

No objections. Sounded like they were unused following rP22404, but doesn't seem so. Happen to know which commit introduced that? (perhaps there is even more unused stuff?)

source/graphics/GameView.cpp
464 ↗	(On Diff #10037)	(There are D1931, D2293, but they don't touch `GameView.cpp`)
902 ↗	(On Diff #10037)	Why not `float(M_PI)`?

In D2342#98054, @elexis wrote:

No objections. Sounded like they were unused following rP22404, but doesn't seem so. Happen to know which commit introduced that? (perhaps there is even more unused stuff?)

Unused after rP22940. I didn't remove methods there, because I had some thoughts about how I can use them. Introduced in rP10548.

source/graphics/GameView.cpp
464 ↗	(On Diff #10037)	Yeah, I have that in mind. First of all I want to remove the public member.
902 ↗	(On Diff #10037)	We use cast to easily find places with an implicit type conversion and for a more strict type check.

If you verified that it works and that it's complete, ok by me.

source/graphics/GameView.cpp
902 ↗	(On Diff #10037)	I suppose the idea is to keep the semantics, i.e. expressing that it is a `conversion`, not a `construction` of a new number (from an existing number)