Subj.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23025: Removes unused methods and hides private member.
- Apply the patch and compile the game
- Run the game and make sure that everything works
- Run tests and make sure that all tests are passed as before the patch.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 9680 Build 16253: Vulcan Build Jenkins Build 16252: Vulcan Build (Windows) Jenkins
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/372/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/graphics/GameView.h | 35| class·CGameView·:·private·Scene | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCGameView:' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/888/display/redirect
Comment Actions
Comment Actions
If you verified that it works and that it's complete, ok by me.
source/graphics/GameView.cpp | ||
---|---|---|
902 | I suppose the idea is to keep the semantics, i.e. expressing that it is a conversion, not a construction of a new number (from an existing number) |