Page MenuHomeWildfire Games
Differential D2346

Moves CSmoothedValue to separate file.
ClosedPublic
Actions

Authored by vladislavbelov on Oct 2 2019, 12:23 AM.

Details

Reviewers
elexis
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23026: Moves CSmoothedValue to separate file.
Summary

Subj.

Test Plan
  1. Apply the patch and compile the game
  2. Run the game and make sure that everything works
  3. Run tests and make sure that all tests are passed as before the patch.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Oct 2 2019, 12:23 AM
Vulcan added a comment.Oct 2 2019, 12:23 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/892/display/redirect

Harbormaster failed remote builds in B9686: Diff 10042!Oct 2 2019, 12:23 AM
Vulcan added a comment.Oct 2 2019, 12:31 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/376/display/redirect

vladislavbelov updated this revision to Diff 10043.Oct 2 2019, 12:34 AM
Vulcan added a comment.Oct 2 2019, 12:34 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/893/display/redirect

Harbormaster failed remote builds in B9687: Diff 10043!Oct 2 2019, 12:34 AM
Vulcan added a comment.Oct 2 2019, 12:35 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/377/display/redirect

elexis accepted this revision.Oct 2 2019, 12:40 AM
elexis added a subscriber: elexis.

See IRC review on http://irclogs.wildfiregames.com/2019-10/2019-10-01-QuakeNet-%230ad-dev.log

source/graphics/SmoothedValue.cpp
26 ↗(On Diff #10043)

+2 spaces

This revision is now accepted and ready to land.Oct 2 2019, 12:40 AM
This revision was landed with ongoing or failed builds.Oct 2 2019, 12:42 AM
Closed by commit rP23026: Moves CSmoothedValue to separate file. (authored by vladislavbelov). · Explain Why
This revision was automatically updated to reflect the committed changes.
vladislavbelov added a commit: rP23026: Moves CSmoothedValue to separate file..

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
graphics/
96 lines
93 lines
54 lines

Diff 10044

View Options

ps/trunk/source/graphics/GameView.cpp

Loading...
View Options

ps/trunk/source/graphics/SmoothedValue.h

Loading...
View Options

ps/trunk/source/graphics/SmoothedValue.cpp

Loading...
Wildfire Games · Phabricator