Page MenuHomeWildfire Games

Cleanup Camera related code.
ClosedPublic

Authored by vladislavbelov on Oct 3 2019, 12:32 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23033: Cleanup Camera related code and uses constant references where possible.
Summary

Subj.

Test Plan
  1. Apply the patch and compile the game
  2. Run the game and make sure that everything works
  3. Run tests and make sure that all tests are passed as before the patch.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Oct 3 2019, 12:32 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/902/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/387/display/redirect

elexis added a subscriber: elexis.Oct 3 2019, 9:27 AM

(no objection if you know what youre doing)

source/graphics/CameraController.h
69 ↗(On Diff #10058)

/**

source/ps/TouchInput.cpp
1 ↗(On Diff #10058)

9

Stan added a subscriber: Stan.Oct 3 2019, 9:54 AM
Stan added inline comments.
source/ps/TouchInput.cpp
131 ↗(On Diff #10058)

I guess you can't do it below because they modify camera state ?

vladislavbelov added inline comments.Oct 3 2019, 11:19 AM
source/ps/TouchInput.cpp
131 ↗(On Diff #10058)

Unfortunately yes, I can't.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 3 2019, 2:59 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.