In rP23020 / D2325 I chose IsMouseOver instead of IsMouseHovering, because that had a public getter and because they appeared to be equivalent.
But when we open the ingame chat dropdown and hover a button, we see the difference, see https://code.wildfiregames.com/D2325#98443.
Hence clarify the comments and pick the right function.
Also removes a comment about nonexisting member from rP128.
Details
Details
- Reviewers
- None
- Commits
- rP23054: Correct button hovering following rP23020 / D2325, clarify difference between…
Notice that the commit didnt change other behavior and that this function / or call to it wasnt changed elsewhere (either by memory or downloading and grepping all commits from a24).
Open the ingame chat dropdown and hover the buttons beneath the list.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/919/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/404/display/redirect
Comment Actions
Related: CGUI::FindObjectUnderMouse, IGUIObject::ChooseMouseOverAndClosest, but Im totally not touching those now.