Page MenuHomeWildfire Games

Fix missing round in Looter
Needs ReviewPublic

Authored by elexis on Oct 5 2019, 10:43 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

As discovered in #5605 / D2327, Looter has a missing round

Missing since rP14247 (Looter techs) or rP7322 (Player.AddResources without round).

Reproduce with kushite hero having Looter bonus attacking gathering units.
Replay here
https://code.wildfiregames.com/D2327#97846

See also http://irclogs.wildfiregames.com/2019-09/2019-09-29-QuakeNet-%230ad-dev.log

Test Plan

See how far we want to escalate the missing round issue this time, see #4099.
Consider floor vs round vs ceil.

Event Timeline

elexis created this revision.Oct 5 2019, 10:43 PM
elexis edited the summary of this revision. (Show Details)Oct 5 2019, 10:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/414/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/929/display/redirect

Shouldn't we only round in the GUI?

Shouldn't we only round in the GUI?

Do we want trade carts with 0.1 profit shown as 0?
Or trade carts with 0.1 profit that show 1 profit per trip but needs 10 trips to add 1?
See also D2327/rP23016, #4099, #3818