Details
- Reviewers
wraitii - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23927: Fix text input max_length attribute. fixes rP15785
Check any text fuzzing you now to make sure one cannot enter more than X characters in the fields with a max_length attribute.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 12688 Build 24591: Vulcan Build Jenkins Build 24590: Vulcan Build (macOS) Jenkins Build 24589: Vulcan Build (Windows) Jenkins Build 24588: arc lint + arc unit
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/974/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/459/display/redirect
Original patch was made by Amplikon, but has been mostly rewritten.
To answer smiley's comments,
Done.
int is used everywhere else except in one place where it uses long for some reason.
Yep, because in this case if the function expect a return type, which was not easily visible without context.
Since apparently I had commented on this before, I have a feeling this would not quite work the way it should in certain cases.
Then again, its just a feeling. Consider that before wasting hours on potentially nothing.
Rebase.
Fix logic.
Add support for max length with paste
Remove casts.
The default case l324 seems useless but I'm not sure. I have not been able to enter it
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2789/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1157/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2829/display/redirect
Thanks for the fair warning, and the time you took to express it :)
Actually, no. That was a snarky at best, counter productive at worst warning.
Regardless, your refactor fixed that bug.
You're missing the case where the user-autocompletes a pseudo, or any JS modifying "caption" in fact. You probably need to add a final check in UpdateText() or in HandleMessage.
Otherwise seems to work.
See D2629 for a bug where text-too-long crashes.
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2832/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2842/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2843/display/redirect