Fix a broken User Report string
ClosedPublic
Actions

Authored by elexis on Mar 19 2017, 5:07 PM.

Details

Reviewers

Gallaecio
s0600204

Commits

rP19324: Fix a broken string in the User Report panel of the main menu.

Trac Tickets

#4388

Summary

As reported in #4388, the user report upload status label in the main menu for some translations shows "$status" instead of the actual current status.
As you can see from the diff, it doesn't use a proper sprintf but some custom replacement of $status in a translated string.
The latter is likely not translated as intended and escaped for some languages.

Instead a usual sprintf should be used.
Notice the status string is translated correctly in formatUserReportStatus.

Test Plan

Enable feedback and restart 0ad. User a non-english language and notice the strings still being translated correctly, so they weren't changed besides the $status one.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Mar 19 2017, 5:07 PM

Harbormaster completed remote builds in B809: Diff 859.Mar 19 2017, 5:07 PM

elexis updated the Trac tickets for this revision.Mar 19 2017, 5:09 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/549/ for more details.

Harbormaster completed remote builds in B809: Diff 859.Mar 19 2017, 5:51 PM

• leper added reviewers: Gallaecio, s0600204.Mar 22 2017, 10:55 PM

Gallaecio accepted this revision.Mar 22 2017, 11:35 PM

This revision is now accepted and ready to land.Mar 22 2017, 11:35 PM

Closed by commit rP19324: Fix a broken string in the User Report panel of the main menu. (authored by elexis). · Explain WhyMar 22 2017, 11:51 PM

This revision was automatically updated to reflect the committed changes.

Thanks for the review