Differential D2415

Refactor ColorActivateFastImpl function
ClosedPublic
Actions

Authored by Silier on Nov 11 2019, 5:52 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23220: Refactor ColorActivateFastImpl function

Summary

Refactor function from rP3764, making it shorter, cleaner and easier to read.

Test Plan

Confirm behaviour was not changed with and without macro

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Nov 11 2019, 5:52 PM

Owners added a subscriber: Restricted Owners Package.Nov 11 2019, 5:52 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/560/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1074/display/redirect

Harbormaster completed remote builds in B9990: Diff 10301.Nov 11 2019, 5:58 PM

Silier added a reviewer: Restricted Owners Package.Nov 17 2019, 5:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2019, 7:17 PM

Closed by commit rP23220: Refactor ColorActivateFastImpl function (authored by Silier). · Explain Why

This revision was automatically updated to reflect the committed changes.

Silier added a commit: rP23220: Refactor ColorActivateFastImpl function.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

graphics/

Color.cpp

11 lines

Diff 10519

View Options

ps/trunk/source/graphics/Color.cpp

Refactor ColorActivateFastImpl functionClosedPublicActions