Page MenuHomeWildfire Games

Petra bot should not treat Boudica as a support female
ClosedPublic

Authored by elexis on Mar 21 2017, 2:54 PM.

Details

Summary

As noted by fatherbushido in http://trac.wildfiregames.com/ticket/4490#comment:17 #4490,
rP19095 added the Female class tag to the briton heroine Boudica, while the tag is intended to only be used for support females and
the petra bot has checks for that class, so coming on and removing that separately.

To prevent template editors from repeating this mistake and to allow modders to add technologies, auras or bonuses that apply to all females (including military females),
using precise language and renaming this class from Female to SupportFemale is preferable, but independent of this removal.

The Chariot class for the same unit was introduced in rP10804 and now seems unused, but cleaning that is not part of the scope of this proposal and
perhaps it might be kept if modders want to add that attack bonus or a tech for chariots.

Test Plan

I don't know how it actually effects the bot. Test not really needed as it restores to the state before that commit.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Mar 21 2017, 2:54 PM
Vulcan added a subscriber: Vulcan.Mar 21 2017, 4:05 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/560/ for more details.

fatherbushido accepted this revision.Mar 21 2017, 6:24 PM
This revision is now accepted and ready to land.Mar 21 2017, 6:24 PM
This revision was automatically updated to reflect the committed changes.