Page MenuHomeWildfire Games

reduce excessive capitalization in game options
ClosedPublic

Authored by Nescio on Nov 23 2019, 1:20 PM.

Details

Summary

Title case is meant for titles, headers, entity names, classes, keys, and button captions (see https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Capitalization ). In the game options about every entry (two exceptions) in the lists is capitalized, which is both unnecessary and excessive. This patch removes title case from the listed items, reserving it for the section headers.

Before:


After:

Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Nov 23 2019, 1:20 PM
Owners added a subscriber: Restricted Owners Package.Nov 23 2019, 1:20 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/626/display/redirect

Nescio added inline comments.Nov 23 2019, 1:22 PM
binaries/data/mods/public/gui/options/options.json
26 ↗(On Diff #10390)

Welcome Screen remains capitalized because it's a name.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1142/display/redirect

Gallaecio accepted this revision.Nov 24 2019, 11:02 AM
Gallaecio added inline comments.
binaries/data/mods/public/gui/options/options.json
26 ↗(On Diff #10390)

Well, I think “Enable the welcome screen” would work as well, since “welcome screen” is a common concept in computer. But I don’t have a strong opinion about it.

This revision is now accepted and ready to land.Nov 24 2019, 11:02 AM
Nescio added inline comments.Nov 25 2019, 11:51 AM
binaries/data/mods/public/gui/options/options.json
26 ↗(On Diff #10390)

Actually I don't feel strongly about this either. Capitalization might be more correct and no capitalization might be more consistent.

Nescio updated this revision to Diff 10420.Nov 25 2019, 11:55 AM

Welcome Screen → welcome screen

Freagarach added inline comments.Nov 25 2019, 11:56 AM
binaries/data/mods/public/gui/options/options.json
26 ↗(On Diff #10390)

At least it should be consistent with the line below, I guess?

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/648/display/redirect

Sorry, a tad too late ;)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1164/display/redirect

Nescio updated this revision to Diff 10421.Nov 25 2019, 12:16 PM

LOS → vision

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/649/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1165/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1007/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/103/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1525/display/redirect

This revision was automatically updated to reflect the committed changes.