As suggested by @wowgetoffyourcellphone (D2371#101856) this patch shows a progress bar when upgrading an entity. The textures from "pack" are reused.
Details
Details
- Reviewers
Silier - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23218: Show progress bar when upgrading entities
Verify this works as intended by upgrading an entity: Verify that the progress bar
- appears when upgrading.
- disappears when canceling upgrade or finishes upgrading.
- updates on progress.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 10128 Build 17173: Vulcan Build Jenkins Build 17172: Vulcan Build (Windows) Jenkins Build 17171: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/646/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1162/display/redirect
Comment Actions
Code looks good, feature should work as intended by reading the code.
I see usage mainly in that player does not have to select entity, he can just hover over it to see progress.
I would maybe consider to add option into the settings or somehow toogle between show always and show default.
Comment Actions
I indeed considered that, but also "pack" does not have that option (probably because it is otherwise not visible whether the entity is packing or not). So I might indeed add an option for this.
Comment Actions
I guess pack could have a visual animation at some point too. Would be fun to have a unit reading IKEA instructions.
Comment Actions
When I applied the patch, it failed to get pictures so i had to copy them manually.
Aside from that, looks good and works.
Comment Actions
Since you just copy that textures, why just not to reuse the original directly?
If artists will want to add special texture for them, they will re-upload them anyway,
Comment Actions
I didn't reuse the "pack"-image because someone who wants to change the textures also needs to touch the StatusBars.js then. Which is not bad for base game, but *is* bad for modders.