Differential D2447

Give a more explicit message when anim mismatches models
ClosedPublic
Actions

Authored by Stan on Nov 29 2019, 6:56 PM.

Tags

None

Subscribers

Restricted Owners Package

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23225: Add a more explicit message when requested animation rig does not match rigged…

Summary

Currently the message doesn't help figuring out the bug.

Test Plan

Agree that the message is more useful now.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Nov 29 2019, 6:56 PM

static_cast

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1174/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1175/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/658/display/redirect

Harbormaster completed remote builds in B10151: Diff 10434.Nov 29 2019, 7:12 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/659/display/redirect

Harbormaster completed remote builds in B10152: Diff 10435.Nov 29 2019, 7:14 PM

Silier added a subscriber: Silier.Nov 29 2019, 7:20 PM

Silier added inline comments.

source/graphics/Model.cpp
478 ↗	(On Diff #10435)	maybe animation %s has %u not sure if current formulation is ok, but i miss there verb

Fix verb

Stan marked an inline comment as done.Nov 29 2019, 7:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/660/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1176/display/redirect

Harbormaster completed remote builds in B10153: Diff 10437.Nov 29 2019, 7:30 PM

Stan mentioned this in rP23195: Horse actors and variants cleaning..Dec 1 2019, 1:59 PM

Silier added a reviewer: Silier.Dec 6 2019, 8:38 PM

This is nice improvement for artists and moders so they get more detailed report about current error.
GetNumBones and GetNumKeys return both size_t what is unsigned int making it safe to convert to unsigned long.

This revision is now accepted and ready to land.Dec 8 2019, 12:57 PM

Closed by commit rP23225: Add a more explicit message when requested animation rig does not match rigged… (authored by Stan). · Explain WhyDec 8 2019, 8:50 PM

This revision was automatically updated to reflect the committed changes.

Stan added a commit: rP23225: Add a more explicit message when requested animation rig does not match rigged….

Owners added a subscriber: Restricted Owners Package.Dec 8 2019, 8:50 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

graphics/

7 lines

Diff 10540

ps/trunk/source/graphics/Model.cpp

Loading...