Page MenuHomeWildfire Games

Fix linting errors in UnitMotionFlying
ClosedPublic

Authored by Stan on Dec 9 2019, 11:23 AM.

Details

Summary

Fix errors reported by the linter.
Don't call class methods and use members instead.

Open question: Should we use class syntax while at it?

Test Plan

Test that everything works.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Dec 9 2019, 11:23 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/722/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1238/display/redirect

Angen added a subscriber: Angen.EditedDec 9 2019, 11:51 AM

Open question: Should we use class syntax while at it?

possibly yes, ideally we should move this to cpp

Stan added a comment.Dec 9 2019, 11:58 AM
In D2457#102995, @Angen wrote:

Open question: Should we use class syntax while at it?

possibly yes, ideally we should move this to cpp

Sounds fun :D

bb added a subscriber: bb.May 1 2020, 6:28 PM
bb added inline comments.
binaries/data/mods/public/simulation/components/UnitMotionFlying.js
67 ↗(On Diff #10542)

could be moved inside the if block

89 ↗(On Diff #10542)

what is the period policy?

108 ↗(On Diff #10542)

cap+period policy?

More downstairs to be checked

223 ↗(On Diff #10542)

newline

224 ↗(On Diff #10542)

not sure about these comments, they seem.... obvious....

Stan updated this revision to Diff 11765.May 1 2020, 7:45 PM
Stan marked 5 inline comments as done.

Fix notes

Stan added inline comments.May 1 2020, 7:46 PM
binaries/data/mods/public/simulation/components/UnitMotionFlying.js
89 ↗(On Diff #10542)

If it is a sentence add a dot I guess.

bb accepted this revision.May 1 2020, 8:10 PM

Add those last two yourself

binaries/data/mods/public/simulation/components/UnitMotionFlying.js
88 ↗(On Diff #11765)

.

160 ↗(On Diff #11765)

.

This revision is now accepted and ready to land.May 1 2020, 8:10 PM
Vulcan added a comment.May 1 2020, 8:15 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1529/display/redirect

Vulcan added a comment.May 1 2020, 8:25 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2057/display/redirect

This revision was automatically updated to reflect the committed changes.
Stan marked 2 inline comments as done.