Page MenuHomeWildfire Games

Skinning optimisations.
AbandonedPublic

Authored by Stan on Dec 9 2019, 5:28 PM.

Details

Reviewers
vladislavbelov
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Trac Tickets
#2026
Summary

See #2026 Based on a patch of @wraitii. The patch by @fsincos was broken for me.

Test Plan

Test I didn't break the rendering.
Run some profiling and see if it's faster.

Event Timeline

Stan created this revision.Dec 9 2019, 5:28 PM
Vulcan added a comment.Dec 9 2019, 5:32 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/723/display/redirect

Vulcan added a comment.Dec 9 2019, 5:51 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/graphics/ModelDef.h
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2011"

source/graphics/ModelDef.h
| 109| »   std::vector<float>·m_UVs;
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'std::vector' is invalid C code. Use --std or --language to configure the language.

source/graphics/ModelDef.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2015"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1239/display/redirect

Stan abandoned this revision.Dec 5 2020, 5:29 PM

I don't care about that anymore + it's broken.