Page MenuHomeWildfire Games

[WIP] Move Unitmotion flying to cpp
Needs ReviewPublic

Authored by Stan on Dec 10 2019, 5:55 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

TBD

Test Plan

TBD

Unit TestsFailed

TimeTest
0 msJenkins > TestComponentScripts::test_scripts
Test failed: L"Running script simulation/components/tests/test_GarrisonHolder.js" Assertion failed: scriptInterface.LoadScript(pathname, content) Test failed: L"Running script simulation/components/tests/test_Health.js"
0 msJenkins > cxxtest-debug-gcc6.xml::[failed-to-read]
Failed to read test report file /zpool0/trunk/cxxtest-debug-gcc6.xml org.dom4j.DocumentException: Error on line 1 of document : Content is not allowed in prolog. at org.dom4j.io.SAXReader.read(SAXReader.java:462)
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAtlasObjectXML::test_parse_attributes1
0 msJenkins > TestAtlasObjectXML::test_parse_attributes2
View Full Test Results (2 Failed · 332 Passed)

Event Timeline

Stan created this revision.Dec 10 2019, 5:55 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1245/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/729/display/redirect

Stan updated this revision to Diff 10556.Dec 10 2019, 8:38 PM

Fix almost all errors, still missing sin cos, euclid distance, and one priority operation

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1247/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/731/display/redirect

Stan updated this revision to Diff 10561.Dec 11 2019, 12:39 PM

Compiling version, Fixed values are weird.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/734/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1250/display/redirect

Stan updated this revision to Diff 10562.Dec 11 2019, 2:07 PM

Fix tests, still not working

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/735/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/CCmpUnitMotionFlying.h
|  34| »   static·void·ClassInit(CComponentManager&·componentManager);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpUnitMotion:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1251/display/redirect

Stan updated this revision to Diff 10563.Dec 11 2019, 2:28 PM

Remove useless interfaces

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/736/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/CCmpUnitMotionFlying.h
|  34| »   static·void·ClassInit(CComponentManager&·componentManager);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpUnitMotion:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1252/display/redirect

Stan updated this revision to Diff 10568.Dec 11 2019, 6:16 PM

Works now!

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/741/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/CCmpUnitMotionFlying.h
|  34| »   static·void·ClassInit(CComponentManager&·componentManager);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpUnitMotion:' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1257/display/redirect

Stan updated this revision to Diff 10576.Dec 13 2019, 6:43 PM

Add interfaces for js components

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/748/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1264/display/redirect

Stan updated this revision to Diff 10595.Dec 14 2019, 5:16 PM

Fix typo, Still runs out of bounds or division by 0...

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/762/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1278/display/redirect

elexis added a subscriber: elexis.Dec 15 2019, 1:44 AM

It's proposed to be moved to C++ for performance?
What about the loss of moddability and extensibility?

Stan added a comment.Dec 15 2019, 9:56 AM

@elexis yeah it's for performance. I'm kind of surprised though the game doesn't go out of sync in MP I guess it has never really been really tested since we don't have many planes.

The C++ code seems less stable (division by 0 overflows on fixed numbers) but I guess it's safer?

So on my end I don't care much as long as I get the features from the two other patches :)