Page MenuHomeWildfire Games
Differential D2463

Refactors ownership of SOverlayTexturedLine in CCmpRangeOverlayRenderer
ClosedPublic
Actions

Authored by vladislavbelov on Dec 11 2019, 10:34 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23270: Refactors ownership of SOverlayTexturedLine in CCmpRangeOverlayRenderer
Summary

Subj.

Test Plan
  1. Apply the patch and compile the game
  2. Make sure that range overlays work as before

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Dec 11 2019, 10:34 PM
Vulcan added a comment.Dec 11 2019, 10:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/742/display/redirect

Stan added a subscriber: Stan.Dec 11 2019, 10:54 PM

Can you improve the description? What does this patch actually do?

source/simulation2/components/CCmpRangeOverlayRenderer.cpp
216 ↗(On Diff #10569)

I thought we should avoid new when possible?

228 ↗(On Diff #10569)

Make this part of the schema?

vladislavbelov added a comment.Dec 11 2019, 11:02 PM
In D2463#103241, @Stan wrote:

Can you improve the description? What does this patch actually do?

I thought it's pretty clear. I just want to remove manual ownership control.

source/simulation2/components/CCmpRangeOverlayRenderer.cpp
216 ↗(On Diff #10569)

We don't have std::make_unique<T> yet (C++14).

228 ↗(On Diff #10569)

It might make sense, but that's not the goal of the patch.

Vulcan added a comment.Dec 12 2019, 10:00 AM

Build was aborted.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1258/display/redirect

Harbormaster failed remote builds in B10283: Diff 10569!Dec 12 2019, 10:00 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 20 2019, 11:33 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP23270: Refactors ownership of SOverlayTexturedLine in CCmpRangeOverlayRenderer (authored by vladislavbelov). · Explain Why
This revision was automatically updated to reflect the committed changes.
vladislavbelov added a commit: rP23270: Refactors ownership of SOverlayTexturedLine in CCmpRangeOverlayRenderer.
Owners added a subscriber: Restricted Owners Package.Dec 20 2019, 11:33 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
source/
simulation2/
components/
59 lines

Diff 10684

View Options

ps/trunk/source/simulation2/components/CCmpRangeOverlayRenderer.cpp

Loading...
Wildfire Games · Phabricator