Fix formation members not getting rotation correctly when IDLE
ClosedPublic
Actions

Authored by Silier on Dec 14 2019, 5:38 PM.

Details

Reviewers: None
Commits: rP23248: Fix formation members not getting rotation correctly when IDLE

Summary

When formation stops moving almost half of members get rotation wrong.

There is function in formation SetInPosition, but I do not think that should be used mainly for that purpose as it is complement to UnsetInPosition what means member leaving position in formation.

So this is setting correct rotation once member gets and stays idle.

Test Plan

Move with formation around, confirm that units gets correct rotation when it stops.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Silier created this revision.Dec 14 2019, 5:38 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1279/display/redirect

Harbormaster failed remote builds in B10313: Diff 10596!Dec 14 2019, 5:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/763/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2019, 9:38 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP23248: Fix formation members not getting rotation correctly when IDLE (authored by Silier). · Explain Why

This revision was automatically updated to reflect the committed changes.

Silier added a commit: rP23248: Fix formation members not getting rotation correctly when IDLE.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

UnitAI.js

10 lines

Diff 10620

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Fix formation members not getting rotation correctly when IDLEClosedPublicActions