Page MenuHomeWildfire Games

Update NVTT to 2.1.1
ClosedPublic

Authored by Itms on Dec 16 2019, 11:32 PM.

Details

Summary

See #4549.

The diff is big, so you might prefer reviewing the git branch at https://github.com/na-Itms/0ad/tree/nvtt.

I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.

Test Plan

Test on Linux (done by me, gcc 8), Windows (done by me), macOS.

Windows Developers will need to build with --large-address-aware if they don't want to hit memory limits when rebuilding all their texture cache.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Dec 16 2019, 11:32 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1292/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/776/display/redirect

Itms added a comment.Dec 16 2019, 11:43 PM

I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.

Welp, it definitely did...

The linux failure is arcanist not patching the build.sh correctly. The windows failure rather looks like the workspace not being properly updated.

Stan added a subscriber: Stan.EditedDec 22 2019, 5:51 PM

Okay so I tested this with and without cache.
I tested it with stella artis and special spec textures
I tested it with delenda est with a modified Units Demo map to be able to display everything (I assume it segfaulted because too many objects) (I had large adress aware.)
I tested it with hyrule conquest (had to fix the mod for A24 first) and I didn't see any breakage.
So it's good for me.

Stan added a comment.Dec 28 2019, 4:25 PM

Haven't tried your branch yet cause cloning the repo would take me ages but I get this warning when building with the current NVTT on a RPI4 without --with-system-nvtt.

CMake Warning (dev) at /usr/share/cmake-3.13/Modules/FindOpenGL.cmake:270 (message):
  Policy CMP0072 is not set: FindOpenGL prefers GLVND by default when
  available.  Run "cmake --help-policy CMP0072" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  FindOpenGL found both a legacy GL library:

    OPENGL_gl_LIBRARY: /usr/lib/arm-linux-gnueabihf/libGL.so

  and GLVND libraries for OpenGL and GLX:

    OPENGL_opengl_LIBRARY: /usr/lib/arm-linux-gnueabihf/libOpenGL.so
    OPENGL_glx_LIBRARY: /usr/lib/arm-linux-gnueabihf/libGLX.so

  OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for
  compatibility with CMake 3.10 and below the legacy GL library will be used.
Call Stack (most recent call first):
  src/CMakeLists.txt:20 (INCLUDE)
This warning is for project developers.  Use -Wno-dev to suppress it.
This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2019, 12:22 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Dec 29 2019, 12:22 PM