This is now handled in a platform-agnostic way by SDL2’s APIs.
Changes at https://github.com/linkmauve/0ad/tree/rm-sys
Differential D2476
Remove obsolete GetVideoMode platform-specifics linkmauve on Dec 17 2019, 12:21 PM. Authored by
Details
This is now handled in a platform-agnostic way by SDL2’s APIs. Changes at https://github.com/linkmauve/0ad/tree/rm-sys
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/777/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/lib/sysdep/os/android/android.cpp | 1| /*·Copyright·(C)·2012·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2012" source/lib/res/graphics/cursor.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1293/display/redirect Comment Actions This now removes almost all platform-specific calls, not just cursors but also clipboards and video modes, replacing them with SDL2 calls. Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/780/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/lib/sysdep/gfx.h | 1| /*·Copyright·(C)·2013·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2013" source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. source/ps/VideoMode.h | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/os/win/wgfx.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/ps/VideoMode.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/lib/sysdep/os/win/wsysdep.cpp | 1| /*·Copyright·(C)·2011·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2011" source/lib/sysdep/os/osx/osx.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" source/lib/sysdep/gfx.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1296/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/781/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/lib/sysdep/os/osx/osx.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" source/lib/sysdep/gfx.h | 1| /*·Copyright·(C)·2013·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2013" source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/os/win/wgfx.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/res/graphics/cursor.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/ps/VideoMode.h | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/gfx.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" source/ps/VideoMode.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/lib/sysdep/os/win/wsysdep.cpp | 1| /*·Copyright·(C)·2011·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2011" Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1297/display/redirect
Comment Actions Fix Stan`’s comments:
Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/782/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/ps/VideoMode.h | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/gfx.h | 1| /*·Copyright·(C)·2013·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2013" source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/os/win/wgfx.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/sysdep/gfx.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" source/lib/res/graphics/cursor.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/sysdep/os/osx/osx.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" source/ps/VideoMode.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/lib/sysdep/os/win/wsysdep.cpp | 1| /*·Copyright·(C)·2011·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2011" Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1298/display/redirect Comment Actions
Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/887/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1403/display/redirect
Comment Actions The latest changes are rebased and pushed at https://github.com/linkmauve/0ad/tree/rm-sys Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1117/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1635/display/redirect Comment Actions This patch fixes the "copy twice" bug described in #3145! Edit: bb tested as well on fedora 29 (see irc today) and also cant reproduce the crash Comment Actions Failing to build on windows. 16>..\..\..\source\lib\sysdep\os\win\wsysdep.cpp(217): error C3861: 'SDL_SetClipboardText': identifier not found [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vc2015\lowlevel.vcxproj]
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1809/display/redirect Comment Actions windows build was fixed
Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2074/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1548/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/macos-differential/659/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/lib/sysdep/gfx.h | 30| namespace·gfx·{ | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespacegfx{' is invalid C code. Use --std or --language to configure the language. source/ps/VideoMode.h | 23| class·CVideoMode | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCVideoMode{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2075/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/macos-differential/660/display/redirect |