Page MenuHomeWildfire Games

Import dladdr() and getcwd() from their correct header
Needs ReviewPublic

Authored by linkmauve on Dec 18 2019, 6:22 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This Unix-only was using the Windows wrapper, for no reason.

Test Plan
  • Test that it still builds on Linux.

Diff Detail

Unit TestsFailed

TimeTest
0 msJenkins > TestSysdep::test_unix_ExecutablePathname
Error: Expected ((unix_ExecutablePathname()).string() == (rootstrw/L"example/executable").string()), found (L"/zpool0/gcc6/binaries/system/test_dbg" != L"/tmp/pyrogenesis-test-sysdep-LLy8dJ/example/executable") Error: Expected ((unix_ExecutablePathname()).string() == (rootstrw/L"example/executable").string()), found (L"/zpool0/gcc6/binaries/system/test_dbg" != L"/tmp/pyrogenesis-test-sysdep-LLy8dJ/example/executable") Error: Expected ((unix_ExecutablePathname()).string() == (rootstrw/L"example/executable").string()), found (L"/zpool0/gcc6/binaries/system/test_dbg" != L"/tmp/pyrogenesis-test-sysdep-LLy8dJ/example/executable")
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAtlasObjectXML::test_parse_attributes1
View Full Test Results (1 Failed · 990 Passed)

Event Timeline

linkmauve created this revision.Dec 18 2019, 6:22 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1305/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/789/display/redirect

vladislavbelov added a subscriber: vladislavbelov.EditedThu, Dec 26, 3:55 PM

It was used for reason to mock these functions in tests. It doesn't use Windows version always afaik.

Also it seems tests are crashed.