Page MenuHomeWildfire Games

Unbind the correct texture slot in SkyManager
ClosedPublic

Authored by linkmauve on Dec 19 2019, 9:27 PM.

Details

Summary

Previously it was unbinding the GL_TEXTURE_2D slot, which would let the GL_TEXTURE_CUBE_MAP bound basically forever, even when not used.

Test Plan

N/A, this change is obviously correct.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

linkmauve created this revision.Dec 19 2019, 9:27 PM
Owners added a subscriber: Restricted Owners Package.Dec 19 2019, 9:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/802/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1318/display/redirect

vladislavbelov accepted this revision.Dec 19 2019, 10:40 PM
vladislavbelov added a subscriber: vladislavbelov.

I tested it on Windows 10 with VS2015 build.

This revision is now accepted and ready to land.Dec 19 2019, 10:40 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Dec 19 2019, 10:41 PM