Page MenuHomeWildfire Games

Adds free camera to developer tools
Needs RevisionPublic

Authored by vladislavbelov on Dec 21 2019, 11:10 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Allows to control camera and fly around maps freely.

Test Plan
  1. Apply the patch and compile the game
  2. Make sure that default camera wasn't changed
  3. Check that the free camera works

Diff Detail

Event Timeline

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/850/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/graphics/GameView.h
|  35| class·CGameView·:·private·Scene
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCGameView:' is invalid C code. Use --std or --language to configure the language.

source/graphics/scripting/JSInterface_GameView.h
|  30| namespace·JSI_GameView
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GameView{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1366/display/redirect

Stan requested changes to this revision.Dec 26 2019, 3:16 PM
Stan added a subscriber: Stan.

I fail to see the real use of it but it could be nice to have dunno. One could use that to script camera actions maybe.

The switch between camera is broken though it should at best copy the current camera position.

IDEA: Since it's a special camera maybe it would be nice to have an indication it's being used such as text on the interface?

source/graphics/FreeCameraController.cpp
196

Epsilon?

198

Unused?

source/graphics/GameView.cpp
174

Sounds bad to hardcode fallback here. Maybe default camera (when there will be the isometric camera

This revision now requires changes to proceed.Dec 26 2019, 3:16 PM
asterix added a subscriber: asterix.Feb 5 2020, 9:27 PM
In D2500#105009, @Stan wrote:

I fail to see the real use of it but it could be nice to have dunno. One could use that to script camera actions maybe.
The switch between camera is broken though it should at best copy the current camera position.
IDEA: Since it's a special camera maybe it would be nice to have an indication it's being used such as text on the interface?

Actually it is used by people that do Lore/history videos and so on Witcher 3 plus a lot of people (Shadiversity and so on) asked it after devs of Kingdom Come Deliverance.