Page MenuHomeWildfire Games

Port scripts to python 3 before doomsday

Authored by Itms on Dec 22 2019, 8:19 PM.



Python 2 will reach its end of life on the new year. We don't have a lot of work to port scripts.

Attached is a patch updating what is needed. I used the opportunity to fix the bugs that I found.

What is missing:

  • I didn't bother with the userreport server which is completely outdated. @vladislavbelov will upload the current code for the server at some point.
  • I should use the opportunity to set svn:executable on some files.
Test Plan

Test the updated scripts.

I noticed that the fontbuilder (with or without the patch) produces slightly different output from what is currently versioned. Maybe we should update the built fonts.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Dec 22 2019, 8:19 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Stan awarded a token.Dec 22 2019, 8:26 PM
Itms added a comment.Dec 22 2019, 10:26 PM

See also D506?

Yes indeed! As mentioned above updating the translation scripts depends on the pology devs. So when I know more, I'll commit this and then I'll commandeer and commit D506 to port the translation scripts.

Stan added a subscriber: Stan.Dec 23 2019, 12:01 PM
Stan added inline comments.
114 ↗(On Diff #10743)

Trailing ';'

asterix updated the Trac tickets for this revision.Mar 17 2020, 8:47 AM
Stan added a subscriber: Nescio.Nov 10 2020, 2:13 PM
Stan added inline comments.
1 ↗(On Diff #10743)

I had no idea this file existed... Refs D2503 by @Nescio
Not sure we need it anymore.

About Pology, the port to Python 3 will take some time (seeing how the last commit is mine). So, if you find any kind of replacement, you might want to consider porting away from Pology, at least for the time being.

wraitii edited the summary of this revision. (Show Details)Dec 2 2020, 11:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2021, 10:25 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Feb 12 2021, 10:25 PM