Page MenuHomeWildfire Games

adjust wall footprints etc
Needs ReviewPublic

Authored by Nescio on Dec 22 2019, 10:46 PM.

Details

Reviewers
bb
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch adjusts the footprints, obstruction sizes, and wall piece lengths; many were actually too large, a few too small.
It is the result of a rather time-consuming trial-and-error process. What I did is place walls in Atlas, select them to show their current footprints, zoom in, then edit the footprint values in their specific templates, relaunch the game, and repeat all steps until the footprint closely fits the visible actor, then move on to the next civ wallset.
(Most wall segments turned out to have the same length (though different depths), so that simplified things a bit.)
The heights are approximate guesses. If anyone knows of an appropiate method to obtain the exact values, please let me know.

Summary list of changes:

  • <Footprint/Square> width and depth determined by repeated trial-and-error (see above)
  • <Footprint/Height> is equal to:
    • <GarrisonHolder/VisibleGarrisonPoints/Archer1/Y> + 1 for wall segments
    • <StatusBars/HeightOffset> - 1 for gates and wall towers
  • <Obstruction/Static> width and depth are equal to <Footprint/Square> width and depth - 1
  • <StatusBars/HeightOffset> is determined by repeated trial-and-error
  • <WallSet/Length> is equal to <Obstruction/Static> width
    • because most wall segments are basically the same for all civs (short is 12, medium 24, long 36), those values are moved to the shared generic parent templates
    • only the ptol and sele segments have different lengths, which is annoying, but I suppose redoing them in Blender is too much work
    • wall towers of different civs have noticably different sizes
  • the skirmish default templates ought to have the dimensions of the largest possible outcome; for the tower, this is cart; for the segments, rome; for the gate, ptol.

[EDIT]: Also adjust footprints etc. for palisades and cart low walls.

Test Plan

Apply the patch, launch Atlas, place walls, select them and zoom in, agree the new footprints are appropiate.

Event Timeline

Nescio created this revision.Dec 22 2019, 10:46 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/867/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1383/display/redirect

elexis added a subscriber: elexis.Dec 23 2019, 3:47 PM

Apply the patch, launch Atlas, place walls, select them and zoom in, agree the new footprints are appropiate.

There's also the wall demo map (perhaps even more than that map, I dont recall exactly).
There is the developer overlay (alt+D) which can be opened during a non-atlas game to see the precise boundary of the obstruction.
This way one can test whether the changed obstruction sizes fit or not.

(The footprint will be used for ungarrisoning positions)

This comment was removed by Nescio.
Nescio updated this revision to Diff 11252.Sat, Feb 1, 8:15 PM
Nescio retitled this revision from adjust wall footprints to adjust wall footprints etc.
Nescio edited the summary of this revision. (Show Details)
  • status bars
  • footprint heights
  • remove trailing zeros
  • include palisades and cart low walls
Vulcan added a comment.Sat, Feb 1, 8:16 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1696/display/redirect

bb requested changes to this revision.Tue, Feb 11, 11:17 PM
bb added a subscriber: bb.

I made a testing map for this patch: you can see the obstruction sizes in game by opening the map ingame, hitting alt+D and toggling the pathfinder overlay (and possibly the obstruction overlay), this will give you a easier way to tweak the obstruction sizes. Many walls already have the correct size, a couple not (the persian walls looked good for example, mostly gates seems a bit "oversized").

The map: (Maybe one could add the palisades too...)

One could instead tweak the units_demo map to place only buildings/walls or so, to get a similar idea...

binaries/data/mods/public/simulation/templates/structures/cart_s_wall_long.xml
14

width -1

34

-1

binaries/data/mods/public/simulation/templates/structures/cart_s_wall_medium.xml
14

same

binaries/data/mods/public/simulation/templates/structures/cart_s_wall_short.xml
14

also

binaries/data/mods/public/simulation/templates/structures/gaul_wall_tower.xml
22

that file doesn't exists

binaries/data/mods/public/simulation/templates/structures/sele_wall_long.xml
26

Missing <

This revision now requires changes to proceed.Tue, Feb 11, 11:17 PM
bb edited reviewers, added: Restricted Owners Package; removed: Restricted Owners Package.Tue, Feb 11, 11:18 PM

Thank you for reviewing this, I appreciate it!

binaries/data/mods/public/simulation/templates/structures/cart_s_wall_long.xml
14

Or footprint +1. Copied from the palisades. I'll have another look.

binaries/data/mods/public/simulation/templates/structures/cart_s_wall_medium.xml
14

idem

binaries/data/mods/public/simulation/templates/structures/cart_s_wall_short.xml
14

idem

binaries/data/mods/public/simulation/templates/structures/gaul_wall_tower.xml
22

You're right. I'm not sure what happened here; maybe I got confused with the gate; it wasn't changed in the initial diff (10750).

binaries/data/mods/public/simulation/templates/structures/sele_wall_long.xml
26

Oops.

Nescio updated this revision to Diff 11330.Wed, Feb 12, 6:32 PM

several corrections

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1747/display/redirect

Also, the current Ptolemaic short wall actor is off-centre:

Nescio updated this revision to Diff 11338.Thu, Feb 13, 9:40 AM

Adjust ptol_wall_short.xml because of rP23494 (thanks, @Stan).

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1749/display/redirect