Units can either build everything or not at all; what entities are in their build list is irrelevant. Although worker elephants can't initiate any foundation, they can finish all structures, twice as fast as any citizen.
This patch removes the worker elephant's ability to build and instead introduces an aura that gives nearby workers +25% build rate (i.e. reducing structure build time by 20%).
As a consequence worker elephants are slightly less effective at game start but more efficient later when assisting larger numbers of units building large structures (e.g. centre, fortress, wonder).
Details
- Reviewers
elexis Feldfeld - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23579: [gameplay-a24] give worker elephants an aura
Apply the patch, play-test with Mauryas, agree this is an improvement.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 10670 Build 18442: Vulcan Build Jenkins Build 18441: Vulcan Build (macOS) Jenkins Build 18440: Vulcan Build (Windows) Jenkins Build 18439: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/880/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1396/display/redirect
I might agree with this, because the only task where an elephant may help is in transporting heavy weights, not in assembling them, and because if it were to help with actual construction (as it does now), then it has the bug that it can build the foundations but not place the foundations (which is logically inconsistent and makes players perform weird actions - placing a foundation with one unit on the other map near the elephant and have the elephant build it. So either the elephant should receive the builder list or have the construction worker property removed, and the latter is the more sensible solution it seems).
The elephant_worker file should be uploaded too (svn add).
That aura file looks weird here on phabricator. What did I do wrong this time. It looks like this on my end:
{ "affects": ["Worker"], "auraDescription": "Workers +20% build rate.", "auraName": "Elephant Workers", "modifications": [ { "value": "Builder/Rate", "multiply": 1.2 } ], "overlayIcon": "art/textures/ui/session/auras/build_bonus.png", "rangeOverlay" : { "lineTexture": "outline_border.png", "lineTextureMask": "outline_border_mask.png", "lineThickness": 0.1 }, "radius": 15, "type": "range" }
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/882/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1398/display/redirect
It's not your fault json files are sometimes recognized as binary files for some reason @elexis is there a workaround?
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/975/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/71/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1493/display/redirect
svn propset svn:mime-type text/json elephant_worker.json
svn propset svn:eol-style native elephant_worker.json
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1598/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1080/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/176/display/redirect
For me a 25% bonus feels kinda low but i could be wrong. As a comparison i wonder by how much celts civilizations build faster than others ?
Celts have a 20% discount on structure time, which is equivalent to a 25% increase in worker build rate.
Worker Elephants are primarily mobile resource dropsites, though.
binaries/data/mods/public/simulation/templates/units/maur_support_elephant.xml | ||
---|---|---|
30 | This tooltip should be changed in my opinion. |
binaries/data/mods/public/simulation/templates/units/maur_support_elephant.xml | ||
---|---|---|
30 | Nice catch! |
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/518/display/redirect
Might be worth checking if there are any tips referencing that as well.
Not in any gui/text/tips/* file.
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1946/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/528/display/redirect