Page MenuHomeWildfire Games

[gameplay] give worker elephants an aura instead
ClosedPublic

Authored by Nescio on Dec 23 2019, 4:16 PM.

Details

Reviewers
elexis
Feldfeld
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23579: [gameplay-a24] give worker elephants an aura
Summary

Units can either build everything or not at all; what entities are in their build list is irrelevant. Although worker elephants can't initiate any foundation, they can finish all structures, twice as fast as any citizen.
This patch removes the worker elephant's ability to build and instead introduces an aura that gives nearby workers +25% build rate (i.e. reducing structure build time by 20%).
As a consequence worker elephants are slightly less effective at game start but more efficient later when assisting larger numbers of units building large structures (e.g. centre, fortress, wonder).

Test Plan

Apply the patch, play-test with Mauryas, agree this is an improvement.

Event Timeline

Nescio created this revision.Dec 23 2019, 4:16 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/880/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1396/display/redirect

elexis added a subscriber: elexis.Dec 23 2019, 6:09 PM

I might agree with this, because the only task where an elephant may help is in transporting heavy weights, not in assembling them, and because if it were to help with actual construction (as it does now), then it has the bug that it can build the foundations but not place the foundations (which is logically inconsistent and makes players perform weird actions - placing a foundation with one unit on the other map near the elephant and have the elephant build it. So either the elephant should receive the builder list or have the construction worker property removed, and the latter is the more sensible solution it seems).

The elephant_worker file should be uploaded too (svn add).

Stan added a subscriber: Stan.Dec 23 2019, 6:20 PM

That would also solve the issue with build vs seeding animations.

The elephant_worker file should be uploaded too (svn add).

Oops, good point!

Nescio updated this revision to Diff 10776.Dec 23 2019, 6:45 PM

now with aura file

That aura file looks weird here on phabricator. What did I do wrong this time. It looks like this on my end:

{
	"affects": ["Worker"],
	"auraDescription": "Workers +20% build rate.",
	"auraName": "Elephant Workers",
	"modifications": [
		{ "value": "Builder/Rate", "multiply": 1.2 }
	],
	"overlayIcon": "art/textures/ui/session/auras/build_bonus.png",
	"rangeOverlay" : {
		"lineTexture": "outline_border.png",
		"lineTextureMask": "outline_border_mask.png",
		"lineThickness": 0.1
	},
	"radius": 15,
	"type": "range"
}

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/882/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1398/display/redirect

Stan added a comment.Dec 23 2019, 9:37 PM

It's not your fault json files are sometimes recognized as binary files for some reason @elexis is there a workaround?

Nescio updated this revision to Diff 10916.Jan 8 2020, 1:26 PM

Tried again, now with svn propset svn:mime-type text/plain elephant_worker.json.

Vulcan added a comment.Jan 8 2020, 1:29 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/975/display/redirect

Vulcan added a comment.Jan 8 2020, 1:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/71/display/redirect

Vulcan added a comment.Jan 8 2020, 1:32 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1493/display/redirect

Nescio updated this revision to Diff 11083.Jan 17 2020, 9:45 PM
Nescio edited the summary of this revision. (Show Details)

svn propset svn:mime-type text/json elephant_worker.json
svn propset svn:eol-style native elephant_worker.json

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1598/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1080/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/176/display/redirect

@ValihrAnt, any thought on this?

@Feldfeld whats your opinion ?

For me a 25% bonus feels kinda low but i could be wrong. As a comparison i wonder by how much celts civilizations build faster than others ?

Celts have a 20% discount on structure time, which is equivalent to a 25% increase in worker build rate.
Worker Elephants are primarily mobile resource dropsites, though.

Oh ok i thought it got removed too. Then I think it's ok.

@Feldfeld if you agree, you may accept the patch :)

Feldfeld accepted this revision.Mar 28 2020, 9:46 AM
This revision is now accepted and ready to land.Mar 28 2020, 9:46 AM
Silier added inline comments.Mar 29 2020, 2:51 PM
binaries/data/mods/public/simulation/templates/units/maur_support_elephant.xml
30

This tooltip should be changed in my opinion.

Nescio added inline comments.Mar 29 2020, 4:28 PM
binaries/data/mods/public/simulation/templates/units/maur_support_elephant.xml
30

Nice catch!

Stan added a comment.Mar 29 2020, 4:30 PM

Might be worth checking if there are any tips referencing that as well.

Nescio updated this revision to Diff 11603.Mar 29 2020, 4:32 PM

Update worker elephant tooltip (cf. D2578).

Owners added a subscriber: Restricted Owners Package.Mar 29 2020, 4:32 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/518/display/redirect

Might be worth checking if there are any tips referencing that as well.

Not in any gui/text/tips/* file.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1946/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/528/display/redirect

This revision was automatically updated to reflect the committed changes.

Thank you! That's one oddity less in game.