Page MenuHomeWildfire Games

Replace glooxwrapper::string with std::string
Needs ReviewPublic

Authored by linkmauve on Wed, Dec 25, 4:43 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

There was no reason that I could find to the existence of this class.

Test Plan

Test the XMPP lobby.

Diff Detail

Event Timeline

linkmauve created this revision.Wed, Dec 25, 4:43 PM
elexis added a subscriber: elexis.Wed, Dec 25, 4:45 PM

There was no reason that I could find to the existence of this class.

I suggest to read the comments in the files you modified.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/888/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/lobby/glooxwrapper/glooxwrapper.h
|  88| namespace·glooxwrapper
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceglooxwrapper{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1404/display/redirect

To get rid of the glooxwrapper, gloox needs to pass C strings not std::strings, so I suggest to abandon the patch.