There was no reason that I could find to the existence of this class.
Details
Details
- Reviewers
- None
Test the XMPP lobby.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- glooxwrapper-string
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 10512 Build 18027: Vulcan Build Jenkins Build 18026: Vulcan Build (Windows) Jenkins Build 18025: arc lint + arc unit
Event Timeline
Comment Actions
There was no reason that I could find to the existence of this class.
I suggest to read the comments in the files you modified.
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/888/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/lobby/glooxwrapper/glooxwrapper.h | 88| namespace·glooxwrapper | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespaceglooxwrapper{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1404/display/redirect
Comment Actions
To get rid of the glooxwrapper, gloox needs to pass C strings not std::strings, so I suggest to abandon the patch.